Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oci-cli: install shell completion #292467

Merged
merged 1 commit into from
Mar 25, 2024
Merged

oci-cli: install shell completion #292467

merged 1 commit into from
Mar 25, 2024

Conversation

maxbrunet
Copy link
Member

@maxbrunet maxbrunet commented Feb 29, 2024 •
edited

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from ilian March 1, 2024 00:15
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3552

SuperSandro2000
SuperSandro2000 reviewed Mar 5, 2024
View reviewed changes
pkgs/tools/admin/oci-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/oci-cli/default.nix Show resolved Hide resolved
pkgs/tools/admin/oci-cli/default.nix Outdated Show resolved Hide resolved
@ambroisie
Copy link
Contributor

Shouldn't the Zsh bashcompinit be left to the user to enable, if they want to make use of it? It should still pick up the bash completion file when enabled IIUC.

@maxbrunet
Copy link
Member Author

Shouldn't the Zsh bashcompinit be left to the user to enable, if they want to make use of it? It should still pick up the bash completion file when enabled IIUC.

That's how it is done for other CLIs (e.g. aws, gcloud...), the completion does not work without bashcompinit (error with complete command not found). These completion function files are lazy loaded, so it only happens when the user needs it, users who do not use it will never notice them and never load bashcompinit

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3680

@SuperSandro2000 SuperSandro2000 merged commit eaa7f09 into NixOS:master Mar 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilian ilian Awaiting requested review from ilian

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxbrunet @nixos-discourse @ambroisie @SuperSandro2000